Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some potential data racing issues #112

Open
ihciah opened this issue Jun 6, 2021 · 0 comments
Open

Some potential data racing issues #112

ihciah opened this issue Jun 6, 2021 · 0 comments

Comments

@ihciah
Copy link

ihciah commented Jun 6, 2021

  1. On the same instance, we operate on the same git index concurrently, which may cuase the results be interdependent. The solution I can think about is to hold a mutex when write the git repo.
  2. Between different instances, git repo is not "refresh"ed. I noticed the refresh call is commented. However, what I want to remind is, even if you refresh or do some git pull --rebase, there could still exist some conflicts that can not be fixed automatically. Maybe you should retry{ modify files?; git add and push?; break; }.

And there's another problem when using git command: The response text and status are not used which causes ignorence of git push failure. For more robustness, maybe a reset --hard can be used on push failure to make sure the failure won't last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant