fix: barchart disappearance bars issue #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nour-borgi
reviewed
Oct 15, 2022
There was a problem hiding this comment.
Tested this, working as expected ! nice job 🚀
One thing, the minimum of the domain axis is set to 0. This is should be discussed with @marrouchi.
marrouchi
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Thanks @yassinedorbozgithub , I left you some comment. Please LTMK if it makes sense to you.
Comment on lines
100
to
+102
| nice: xAxis.nice || 0, | ||
| reverse: isRTL, | ||
| domain: [0, xAxisDomainMaxValue], |
There was a problem hiding this comment.
Suggested change
| nice: xAxis.nice || 0, | |
| reverse: isRTL, | |
| domain: [0, xAxisDomainMaxValue], | |
| nice: typeof xAxis.nice !== 'undefined' ? xAxis.nice : 1, | |
| reverse: isRTL, |
Note that values could be negative, so we cannot set zero as lower band. By default the scale will compute the min and max by using the xAxis.domainKey, so there's no need to re-calculate the max value. I think we should set nice to "1" if none is provided to solve the issue.
There was a problem hiding this comment.
Hey @marrouchi still have the problem after applying the request update
| @@ -172,6 +174,7 @@ export default class BarChart extends mixins(ToggleDatumMixin) { | |||
| domainKey: xAxis.domainKey, | |||
| nice: xAxis.nice || 0, | |||
| reverse: isRTL, | |||
| domain: [0, xAxisDomainMaxValue], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I find that Gamma data is hidden from the bar chart when we click on the legend at the bottom of the chart as mentioned in the screenshot below.
This PR fixes this issue.
Fixes #71
Type of change
Please delete options that are not relevant.
Checklist: