-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to detect the missing type checks #1
Comments
Hi @citypw, we did not encouter any DWARF v5 errors yet. But, maybe you want to upgrade the Ghidra version in our From the output I cannot really see what your TA is doing. Note that the TA is only considered vulnerable if the check is missing AND one of the params is used as a memref. |
@0ddc0de DWARF v5 is merged in Ghidra v11.1.2: NationalSecurityAgency/ghidra@44eedbe GC is failed to build with Ghidra v11.x.x:
The latest versions of Ghidra and Ghidrathon are failed to build due to something went wrong with JEP:
|
Yea, I remember that setting this up was painful, hence the Docker setup. Are you targeting proprietary TAs or can you compile the TA yourself? |
Good point! I'm tweaking a TA from OPTEE's template with source code. Will let u know the result. Thanks. |
I built the secure_storage_ta with the "-gdwarf-4" flag, but some sections seems still appear to be using DWARF v5. This can be observed by:
The current implementation of GC is only targeting functions like TA_InvokeCommandEntryPoint. The proprietary TA may be putting all code into that function. However, the optee_example template performs type checks in functions called by TA_InvokeCommandEntryPoint, as seen in this example: This is likely the reason that I got false positives. Do you have plans to support checks for the optee template in the future? From my perspective, GC can be very powerful and easy to integrated with typical QA/automation procedure. Thanks. |
@citypw, sorry for the late response, but I currently don't have the resources to actively maintain this project. The secure storage TA you're referring to looks very similar to some of our test cases. I noticed that a couple of libs were missing and added those with the latest commit 4eb7386. You should now be able to compile all tests with Let me know if this works for you! |
Hello GC maintainers, I've removed all type check in a TA and try to test if GC can detect the check was missing but it seem thing went wrong. Have you guys done the test on DWARF v5 that was supported not long ago in Ghidra?
The text was updated successfully, but these errors were encountered: