Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Message can be edited #415

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[Feature] Message can be edited #415

merged 1 commit into from
Mar 10, 2022

Conversation

EliasBoulharts
Copy link
Collaborator

No description provided.

@EliasBoulharts EliasBoulharts linked an issue Mar 7, 2022 that may be closed by this pull request
Support page enhancement #399
Open
4 tasks
@EliasBoulharts EliasBoulharts force-pushed the support_page_enhancement branch 3 times, most recently from 46a6d78 to b8760c5 Compare March 9, 2022 09:14
@Sispheor
Copy link
Contributor

Sispheor commented Mar 9, 2022

Simple v1: As an admin I can edit all message
As a user I can update my message.
Editing a message doesn't change the owner.

We'll see in a V2 how to manage message version.

Sispheor
Sispheor requested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@Sispheor Sispheor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done before merging this one

@EliasBoulharts EliasBoulharts force-pushed the support_page_enhancement branch from b8760c5 to 7af2c4e Compare March 9, 2022 11:53
Sispheor
Sispheor requested changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@Sispheor Sispheor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests to be added

@EliasBoulharts EliasBoulharts force-pushed the support_page_enhancement branch from 7af2c4e to 456596b Compare March 10, 2022 09:54
@EliasBoulharts EliasBoulharts force-pushed the support_page_enhancement branch from 456596b to cc55592 Compare March 10, 2022 14:23
@Sispheor Sispheor merged commit 15ff5be into HewlettPackard:dev Mar 10, 2022
@Sispheor
Copy link
Contributor

LGTM 👍

@EliasBoulharts EliasBoulharts deleted the support_page_enhancement branch March 10, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sispheor Sispheor Sispheor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support page enhancement
2 participants
@EliasBoulharts @Sispheor