Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StarkConfig Validation Functionality #22

Closed
Okm165 opened this issue Dec 26, 2023 · 1 comment · Fixed by #52
Closed

Implement StarkConfig Validation Functionality #22

Okm165 opened this issue Dec 26, 2023 · 1 comment · Fixed by #52
Assignees
@neotheprogramist
Labels
Cairo enhancement New feature or request

Comments

@Okm165
Copy link
Collaborator

Okm165 commented Dec 26, 2023

We are initiating a task to develop a validation function for StarkConfig objects. This function, to be named stark_config_validate, will be responsible for ensuring the integrity and correctness of StarkConfig objects. It will include a series of checks and validations tailored to our specific operational and security needs.
Reference: https://vscode.dev/github/Okm165/cairo-lang/blob/v0.11.0-run-proof-sw-patch/cairo-lang-0.11.0/starkware/cairo/stark_verifier/core/config.cairo#L42
@neotheprogramist neotheprogramist self-assigned this Dec 28, 2023
@neotheprogramist neotheprogramist added enhancement New feature or request Cairo labels Dec 28, 2023
@neotheprogramist neotheprogramist moved this from Todo to In Progress in Cairo Verifier Dec 28, 2023
@neotheprogramist
Copy link
Contributor

neotheprogramist commented Jan 3, 2024 •
edited
Loading

Functions that needs to be implemented:

  • stark_config_validate
  • proof_of_work_config_validate
  • traces_config_validate
  • validate_vector_commitment
  • fri_config_validate
  • fri_layers_config_validate

@tiagofneto tiagofneto linked a pull request Jan 5, 2024 that will close this issue
Stark Config Validation #41
Closed
@neotheprogramist neotheprogramist moved this from In Progress to Review in Cairo Verifier Jan 7, 2024
@neotheprogramist neotheprogramist moved this from Review to In Progress in Cairo Verifier Jan 9, 2024
@neotheprogramist neotheprogramist linked a pull request Jan 10, 2024 that will close this issue
Validation #52
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cairo Verifier Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neotheprogramist neotheprogramist

Labels
Cairo enhancement New feature or request
Projects
Cairo Verifier
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validation HerodotusDev/integrity
Stark Config Validation HerodotusDev/integrity
2 participants
@Okm165 @neotheprogramist