From 957a20df5a9b880b1c2837a1c2e1fe30e1d0c65c Mon Sep 17 00:00:00 2001
From: Bartosz Nowak <bartekn337@gmail.com>
Date: Wed, 11 Sep 2024 15:02:36 +0200
Subject: [PATCH] fix hash calc error

---
 src/air/public_input.cairo   | 5 +++--
 src/stark/stark_commit.cairo | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/air/public_input.cairo b/src/air/public_input.cairo
index 864b6ab2..abbbda9e 100644
--- a/src/air/public_input.cairo
+++ b/src/air/public_input.cairo
@@ -127,6 +127,7 @@ fn hash_data_init(
     n_verifier_friendly_commitment_layers: felt252
 ) {
     hash_data.append(n_verifier_friendly_commitment_layers);
+    hash_data.append(*public_input.log_n_steps);
     hash_data.append(*public_input.range_check_min);
     hash_data.append(*public_input.range_check_max);
     hash_data.append(*public_input.layout);
@@ -139,6 +140,7 @@ fn hash_data_init(
     public_input: @PublicInput,
     _n_verifier_friendly_commitment_layers: felt252
 ) {
+    hash_data.append(*public_input.log_n_steps);
     hash_data.append(*public_input.range_check_min);
     hash_data.append(*public_input.range_check_max);
     hash_data.append(*public_input.layout);
@@ -220,8 +222,7 @@ mod tests {
         let public_input = get();
         let hash = get_public_input_hash(@public_input, 0);
         assert(
-            hash == 0x1c3097c2a1665c78d69edc47ff35a3f3c9c0678e3daaa74d2b68331a5757a37,
-            'Hash invalid'
+            hash == 0xaf91f2c71f4a594b1575d258ce82464475c82d8fb244142d0db450491c1b52, 'Hash invalid'
         )
     }
 }
diff --git a/src/stark/stark_commit.cairo b/src/stark/stark_commit.cairo
index 111c7ae9..9109cf27 100644
--- a/src/stark/stark_commit.cairo
+++ b/src/stark/stark_commit.cairo
@@ -44,7 +44,7 @@ fn stark_commit(
     unsent_commitment: @StarkUnsentCommitment,
     config: @StarkConfig,
     stark_domains: @StarkDomains,
-    contract_address_1: ContractAddress,
+    contract_address: ContractAddress,
 ) -> StarkCommitment {
     // Read the commitment of the 'traces' component.
     let traces_commitment = traces_commit(ref channel, *unsent_commitment.traces, *config.traces,);
@@ -73,7 +73,7 @@ fn stark_commit(
         interaction_after_composition,
         *stark_domains.trace_domain_size,
         *stark_domains.trace_generator,
-        contract_address_1,
+        contract_address,
     );
 
     // Generate interaction values after OODS.