Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #95

Open
maxbriel opened this issue Jun 6, 2023 · 0 comments
Open

[BUG] #95

maxbriel opened this issue Jun 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@maxbriel
Copy link
Collaborator

maxbriel commented Jun 6, 2023

Describe the bug
Missing a / after the MODELS_PATH makes it impossible to use the CMD package.

To Reproduce
Steps to reproduce the behavior:

  1. from hoki.load import set_models_path
  2. set_models_path("path/to/models")
  3. reload kernel
  4. `from hoki.cmd import CMD
  5. mycmd = CMD(input_file)
  6. run mycmd.make(mag_filter='V', col_filters=['B', 'V'])

Expected behavior
Code generates a CMD and runs for a long duration. Code does should not terminate in a few seconds.

Additional context
Might be impacting other areas too.

Fix should be done when setting the MODELS_PATH. The current assert os.path.isdir() does not catch a missing / at the end of the path.

@maxbriel maxbriel added the bug Something isn't working label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant