Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min threshold should not be 0 #73

Open
spengrah opened this issue Oct 31, 2024 · 1 comment
Open

min threshold should not be 0 #73

spengrah opened this issue Oct 31, 2024 · 1 comment

Comments

@spengrah
Copy link
Member

add the following logic to the top of the _setThresholdConfig() function:

// min must be greater than zero
    if (_config.min == 0) revert InvalidThresholdConfig();
@spengrah spengrah added this to HSG v2 Oct 31, 2024
@spengrah spengrah converted this from a draft issue Oct 31, 2024
@TheMarvelFan
Copy link

Hi @spengrah ,

I would like to work on this issue if no one else is .

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
HSG v2
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spengrah @TheMarvelFan