Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow symfony 6 #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

allow symfony 6 #39

wants to merge 3 commits into from

Conversation

mykiwi
Copy link
Contributor

@mykiwi mykiwi commented Jun 7, 2022 •
edited
Loading

Fixes #37

@mykiwi mykiwi marked this pull request as ready for review June 7, 2022 10:16
@deguif
Copy link
Collaborator

deguif commented Jun 7, 2022

Thanks @mykiwi
There is some issue with the CI as it's still configured for running on travis. I hope to be able to migrate to GA soon.

@mykiwi
Copy link
Contributor Author

mykiwi commented Jun 19, 2022

please take a look at #39 as base for github actions

@kevincerro
Copy link

This can be merged? @deguif
We need to use php8 also

@deguif
Copy link
Collaborator

deguif commented Nov 8, 2023

@mykiwi would you be able to rebase this PR?
I introduced support for PHP 8.0 in another PR as there were some fixes to make in order to make CI happy.

@mykiwi mykiwi changed the title allow php 8 & symfony 6 allow symfony 6 Nov 8, 2023
@mykiwi
Copy link
Contributor Author

mykiwi commented Nov 8, 2023 •
edited
Loading

there is an issue with https://github.com/SymfonyTest/symfony-bundle-test // poke @Nyholm
I will try to update it if I find the time to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deguif deguif deguif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8 support
3 participants
@mykiwi @deguif @kevincerro