Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #37

Open
lobodol opened this issue Mar 29, 2021 · 4 comments · May be fixed by #39
Open

PHP 8 support #37

lobodol opened this issue Mar 29, 2021 · 4 comments · May be fixed by #39

Comments

@lobodol
Copy link

lobodol commented Mar 29, 2021

Hi there,

I'm using this bundle for my website, and I'd like to upgrade to PHP 8.
Unfortunately, the constraint for php is ^7.1 in composer.json.

Do you plan to make the bundle compatible with php 8?

Additional, I ran a check on bundle sources using this and no incompatibility was detected, pretty good news.

Regards,

@deguif
Copy link
Collaborator

deguif commented Mar 30, 2021

@lobodol yes absolutely.
Give me some extra time and this will be done (CI to adapt, ...).

@lobodol
Copy link
Author

lobodol commented Mar 30, 2021

Great! I would be glad to help you if you want me to.

@lobodol
Copy link
Author

lobodol commented Jun 19, 2021

Hi, any news?

@grekpg
Copy link

grekpg commented Nov 10, 2021

any news ?

@mykiwi mykiwi linked a pull request Jun 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants