Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected performance unclear from vignette #2

Open
t-silvers opened this issue Jun 5, 2019 · 1 comment
Open

Expected performance unclear from vignette #2

t-silvers opened this issue Jun 5, 2019 · 1 comment

Comments

@t-silvers
Copy link

From the publication and vignette here, it's unclear what is the expected performance of the model. For instance, in BasicExample.ipynb your model assigns weight to each explanatory variable. In the publication, the top 100 genes are selected for further analysis (how? top betas? What parameters yielded those results?).

Some clearer explanations and examples on how you would recommend tuning parameters and training the model would be helpful to include in this repo. For scientific purposes, it would also help in reproducing results from the publication.

Thanks

@HaohanWang
Copy link
Owner

Hi, we selected the top 100 genes based on the absolute values of betas.

In our paper, we noticed that tuning the parameters according to the desired number of SNPs is a good strategy.

This repository only serves as an example for people who are interested to use it, if you want to replicate the results for scientific purpose, I'm happy to share the private repo with all the scripts with you. (I will edit the README to avoid further confusion of others about this point.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants