From 0de9fe42e7444d2901f49825a8ec38bd19f00cf3 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 5 Jun 2017 14:47:16 +0900 Subject: [PATCH 1/5] When boxes is empty, it throws an error. --- lib/multibox_encoder.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/multibox_encoder.py b/lib/multibox_encoder.py index 1290c5e..29e4b47 100644 --- a/lib/multibox_encoder.py +++ b/lib/multibox_encoder.py @@ -88,5 +88,7 @@ def decode(self, loc, conf, nms_threshold, conf_threshold): all_boxes.append(label_boxes[i]) all_labels.append(label) all_scores.append(label_scores[i]) - - return np.stack(all_boxes), np.stack(all_labels), np.stack(all_scores) + if len(all_boxes) != 0 : + return np.stack(all_boxes), np.stack(all_labels), np.stack(all_scores) + else: + return np.zeros(0),np.zeros(0),np.zeros(0) From 9f60f422fbedebd5659f3c3796c0766c477cdd42 Mon Sep 17 00:00:00 2001 From: unknown Date: Mon, 5 Jun 2017 17:13:53 +0900 Subject: [PATCH 2/5] refactored on plint, flake8 and so on --- lib/multibox_encoder.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/multibox_encoder.py b/lib/multibox_encoder.py index 29e4b47..ecb9ffd 100644 --- a/lib/multibox_encoder.py +++ b/lib/multibox_encoder.py @@ -88,7 +88,8 @@ def decode(self, loc, conf, nms_threshold, conf_threshold): all_boxes.append(label_boxes[i]) all_labels.append(label) all_scores.append(label_scores[i]) - if len(all_boxes) != 0 : - return np.stack(all_boxes), np.stack(all_labels), np.stack(all_scores) - else: - return np.zeros(0),np.zeros(0),np.zeros(0) + if all_boxes: + return (np.stack(all_boxes), + np.stack(all_labels), + np.stack(all_scores)) + return np.empty(0), np.empty(0), np.empty(0) From 20a4680d7d278fdcd02b7c3a5b95bcd07ca9fa07 Mon Sep 17 00:00:00 2001 From: sitifukujin Date: Tue, 6 Jun 2017 11:43:32 +0900 Subject: [PATCH 3/5] Refine only on flake8 --- lib/multibox_encoder.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/multibox_encoder.py b/lib/multibox_encoder.py index ecb9ffd..6a075c8 100644 --- a/lib/multibox_encoder.py +++ b/lib/multibox_encoder.py @@ -88,8 +88,9 @@ def decode(self, loc, conf, nms_threshold, conf_threshold): all_boxes.append(label_boxes[i]) all_labels.append(label) all_scores.append(label_scores[i]) - if all_boxes: - return (np.stack(all_boxes), - np.stack(all_labels), - np.stack(all_scores)) - return np.empty(0), np.empty(0), np.empty(0) + if len(all_boxes) > 0: + return np.stack(all_boxes), \ + np.stack(all_labels), \ + np.stack(all_scores) + else: + return np.empty(0), np.empty(0), np.empty(0) From acf927de0f64ca447fedfae127d659ff4226334b Mon Sep 17 00:00:00 2001 From: sitifukujin Date: Tue, 6 Jun 2017 15:56:33 +0900 Subject: [PATCH 4/5] chage to empty(0,4) --- lib/multibox_encoder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/multibox_encoder.py b/lib/multibox_encoder.py index 6a075c8..6648490 100644 --- a/lib/multibox_encoder.py +++ b/lib/multibox_encoder.py @@ -93,4 +93,4 @@ def decode(self, loc, conf, nms_threshold, conf_threshold): np.stack(all_labels), \ np.stack(all_scores) else: - return np.empty(0), np.empty(0), np.empty(0) + return np.empty((0,4)), np.empty((0,4)), np.empty((0,4)) From 601ed2f12abbcd0f51792898b2ca0ee9c51e70cf Mon Sep 17 00:00:00 2001 From: sitifukujin Date: Tue, 6 Jun 2017 17:06:47 +0900 Subject: [PATCH 5/5] change to "return np.empty((0,4)), np.empty(0), np.empty(0)" --- lib/multibox_encoder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/multibox_encoder.py b/lib/multibox_encoder.py index 6648490..96edfc0 100644 --- a/lib/multibox_encoder.py +++ b/lib/multibox_encoder.py @@ -93,4 +93,4 @@ def decode(self, loc, conf, nms_threshold, conf_threshold): np.stack(all_labels), \ np.stack(all_scores) else: - return np.empty((0,4)), np.empty((0,4)), np.empty((0,4)) + return np.empty((0,4)), np.empty(0), np.empty(0)