Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #10

Open
4 tasks
ThibaultLesuisse opened this issue Nov 20, 2022 · 0 comments
Open
4 tasks

Review #10

ThibaultLesuisse opened this issue Nov 20, 2022 · 0 comments

Comments

@ThibaultLesuisse
Copy link
Collaborator

  • Deepflat: I don't see any JSdoc being present on the deepFlat method. The rest seems pretty good 👍. Could you just add a JSDoc
  • Difference: Don't see the solution to this exercise
  • Intersection: Make sure the intersectSol also has a JSDoc. You could also try to use the import/export with babel to actually use the intersection.js file. The tests seems pretty good
  • Slit Object: Also no JsDoc on the splitObject function. Try to add it to make sure the behaviour is there. Strategy and Implementation seem good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThibaultLesuisse