Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order better the Collections info dropdown #567

Open
EdwardMoyse opened this issue Mar 27, 2023 · 10 comments
Open

Order better the Collections info dropdown #567

EdwardMoyse opened this issue Mar 27, 2023 · 10 comments

Comments

@EdwardMoyse
Copy link
Collaborator

When we open the Collections Info windows, the collections dropdown is currently unsorted. See below.

What would be ideal is to divide it into different types of collections. Or we add another dropdown to select the type, with this dropdown then only showing collections of the requested type.

If all of this is too hard (or as a stopgap) we should at least sort it alphabetically.

image

@Krrish-29
Copy link

Hi i would like to resolve the issue , so can you help me on how can i replicate the situation.

@EdwardMoyse
Copy link
Collaborator Author

Hi @Krrish-29 - that would be great! Firstly, you need to check out and run Phoenix locally:
https://github.com/HSF/phoenix/blob/main/CONTRIBUTING.md
(please let us know if anything is incorrect/unclear in the documentation? It has been a while since we last did a review)

Secondly, navigate to the ATLAS example, and open the collections tab:
Collections

This popup is the "collections info overlay":
https://github.com/HSF/phoenix/tree/main/packages/phoenix-ng/projects/phoenix-ui-components/lib/components/ui-menu/collections-info/collections-info-overlay

In PhoenixLoader::getCollection you can see that the event data is sorted into "ObjectTypes" ... I don't think we have an easy way to get this yet in the GUI. Probably the best/easiest is to modify getCollections to return the types, instead of just the names... i.e. return a dictionary with the type as the key, and the collection names as the payload.

@Pratz2005
Copy link
Contributor

hello, I would like to work on this issue, How exactly do you want it sorted, alphabetically or by type?

@EdwardMoyse
Copy link
Collaborator Author

EdwardMoyse commented Dec 13, 2024 via email

@Pratz2005
Copy link
Contributor

ok i will start working on it

@Pratz2005
Copy link
Contributor

Can you help me understand what the different types are?

@EdwardMoyse
Copy link
Collaborator Author

See this comment:

In PhoenixLoader::getCollection you can see that the event data is sorted into "ObjectTypes" ... I don't think we have an easy way to get this yet in the GUI. Probably the best/easiest is to modify getCollections to return the types, instead of just the names... i.e. return a dictionary with the type as the key, and the collection names as the payload.

@Pratz2005
Copy link
Contributor

image

Is this fine?

I updated the getCollections function in pheonixloader to return a dictionary with type as key and collection names as payload then changed teh html file and ngOnInit hook.

@Pratz2005
Copy link
Contributor

Hi @EdwardMoyse can I get an update on this?

@EdwardMoyse
Copy link
Collaborator Author

Sorry, yes that is exactly what I was thinking of!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants