Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit conventions and releases #424

Open
9inpachi opened this issue Apr 23, 2022 · 3 comments
Open

Commit conventions and releases #424

9inpachi opened this issue Apr 23, 2022 · 3 comments

Comments

@9inpachi
Copy link
Collaborator

I think we need to rethink our commit conventions. Our release notes have duplicated commits in them. See https://github.com/HSF/phoenix/releases/tag/v2.7.0

One recommendation I have is to not use the conventions for ordinary commits but only for when we merge a pull request to master. We already have a workflow where each feature is merged through a pull request, so it should work.

CC: @EdwardMoyse

@EdwardMoyse
Copy link
Collaborator

This sounds like a good idea to me! I just tried it with the MR I accepted on Wednesday:
ff9f733

@9inpachi
Copy link
Collaborator Author

With our latest release, I found that merge commits are not included in the CHANGELOG. This is problematic. Maybe we should configure our changelog to use PRs for release notes instead.

@9inpachi
Copy link
Collaborator Author

9inpachi commented Jun 2, 2022

An option for PR-based changelog: https://github.com/lerna/lerna-changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants