Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time information and realistic animations #406

Open
DraTeots opened this issue Feb 19, 2022 · 2 comments
Open

Time information and realistic animations #406

DraTeots opened this issue Feb 19, 2022 · 2 comments

Comments

@DraTeots
Copy link
Collaborator

Dear developers,
As I saw the examples, event data of them don't have actual time information. So two questions:

  1. Is it correct that currently phoenix doesn't works anyhow with the right times and the animation is just a visual effect.
  2. Are there plans to work with timing information and provide realistic animations?

The background of the question, at HallD in Jefferson Lab was this event viewer:

https://halldweb.jlab.org/talks/2018/HDvis-Video/js/event.html#

It is not fancy but has real time information from the experiment. And our experience of using it was that it gave very valuable debugging information for people working on the real data reconstruction. At least it almost instantly revealed several bugs and lead to several enhancements. So it was proven to be valuable.

Now I'm one of developers working on EIC Athena collaboration software. And we desperately want to start working on something to better represent our simulation/reconstruction data and for sure phoenix effort is something that we seriously consider to join.

@EdwardMoyse
Copy link
Collaborator

Hi Dmitri,

This has been raised before and it's certainly something we'd be interested in supporting. Adding the time information to the Event Data Model (EDM) would be the first step, and should be pretty trivial. What is your event format? Do you have any examples we could look at?

Secondly we need to work out how to animate this - this is probably quite a bit more work, but still doable.

What might be a good idea is if you could join a Phoenix developer chat (Wednesday at 3pm, Central European Time) so we can discuss this "in person"

@9inpachi
Copy link
Collaborator

9inpachi commented Feb 19, 2022

Hi Dmitry,

If you would like to dig into the code a bit, you can take a look at the AnimationsManager which handles all the animation stuff.

Now based on the event viewer you shared, we also have ways to animate the camera through the scene. It's possible to pretty much do any kind of animation without having to dive deep into the Phoenix core and just updating the AnimationsManager. There is also a possibility to just use Phoenix as a dependency and handle the animations in another project entirely.

All in all, introducing and handling time information in animations shouldn't be unrealistically hard but it heavily depends on the requirements and how generic we want it to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants