Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add moveLeftHandle and moveRightHandle methods #42

Closed

Conversation

brendanlensink
Copy link

Fixes #17

Adds the moveLeftHandle and moveRightHandle methods to the TrimmerView.
It's worth noting this will allow you to set the right handle to the left of the left handle and vice versa if you aren't careful, not sure if this is something you'd like to handle or not.

@ghost
Copy link

ghost commented Jan 24, 2019

DeepCode analyzed this pull request.
There are no new issues.

@HHK1 HHK1 self-requested a review February 12, 2019 14:05
Copy link
Owner

@HHK1 HHK1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing ! There is another PR (#41) trying to add the same functionality, and I believe that the same thing is missing in your contribution.
On top of moving the left and right panes, the scroll view also needs to be scrolled if the selected time is not included in the currently selected time range.

@farismhmd1
Copy link

Hi,
I used pod file in my project. but these changes are not there in the latest version. why these changes are not in the master?

@HHK1
Copy link
Owner

HHK1 commented Aug 9, 2021

Because the implementation is not complete, and merging this to master would result in bug tickets. I'd rather have a missing feature, than a buggy one. If you want this feature, please consider opening a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to slide the video to a particular position in trimmerView using start and end points
3 participants