From ab778e8679caac24d604f63a27db0f046cd626cf Mon Sep 17 00:00:00 2001 From: Jana Date: Wed, 6 Dec 2023 12:53:12 +0100 Subject: [PATCH] fixing overlaps in ECAL inclined --- .../compact/FCCee_ECalBarrel.xml | 11 +++++- .../compact/FCCee_ECalBarrel_calibration.xml | 33 ++++++++++++---- .../FCCee_ECalBarrel_thetamodulemerged.xml | 11 +++++- ...alBarrel_thetamodulemerged_calibration.xml | 25 ++++++++++-- ..._ECalBarrel_thetamodulemerged_upstream.xml | 28 +++++++++++--- .../compact/FCCee_ECalBarrel_upstream.xml | 38 ++++++++++++++----- .../compact/FCChh_ECalBarrel_Common.xml | 9 +++++ .../FCChh_ECalBarrel_Common_calibration.xml | 33 ++++++++++------ .../FCChh_ECalBarrel_Common_upstream.xml | 30 +++++++++------ .../src/ECalBarrelInclined_geo.cpp | 6 ++- 10 files changed, 169 insertions(+), 55 deletions(-) diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel.xml index e9d45224..2fd46fce 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel.xml @@ -41,7 +41,7 @@ - + @@ -52,6 +52,11 @@ + + + + + @@ -106,6 +111,10 @@ + + + + diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_calibration.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_calibration.xml index e6d52df6..a75e248c 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_calibration.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_calibration.xml @@ -1,6 +1,14 @@ - + + - + Settings for the inclined EM calorimeter. The barrel is filled with liquid argon. Passive material includes lead in the middle and steal on the outside, glued together. @@ -33,7 +41,7 @@ - + @@ -44,6 +52,11 @@ + + + + + @@ -56,7 +69,7 @@ taking into account the angular projection effect --> - + @@ -66,7 +79,7 @@ - + @@ -74,7 +87,7 @@ - + system:4,cryo:1,type:3,subtype:3,layer:8,module:11,eta:9 @@ -93,11 +106,15 @@ - + + + + + @@ -132,4 +149,4 @@ - \ No newline at end of file + diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml index 9411b7dc..352596c1 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml @@ -42,7 +42,7 @@ - + @@ -53,6 +53,11 @@ + + + + + @@ -107,6 +112,10 @@ + + + + diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_calibration.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_calibration.xml index a4f8e444..eb5a9e86 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_calibration.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_calibration.xml @@ -1,6 +1,14 @@ - + + - + Settings for the inclined EM calorimeter. The barrel is filled with liquid argon. Passive material includes lead in the middle and steal on the outside, glued together. @@ -34,7 +42,7 @@ - + @@ -45,6 +53,11 @@ + + + + + @@ -99,6 +112,10 @@ + + + + @@ -133,4 +150,4 @@ - \ No newline at end of file + diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_upstream.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_upstream.xml index 8a37644b..1fbe2656 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_upstream.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged_upstream.xml @@ -1,6 +1,14 @@ - + + - + Settings for the inclined EM calorimeter. The barrel is filled with liquid argon. Passive material includes lead in the middle and steal on the outside, glued together. @@ -11,7 +19,8 @@ - + + @@ -34,7 +43,7 @@ - + @@ -45,6 +54,11 @@ + + + + + @@ -99,6 +113,10 @@ + + + + @@ -133,4 +151,4 @@ - \ No newline at end of file + diff --git a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_upstream.xml b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_upstream.xml index 20e4a308..e311407d 100644 --- a/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_upstream.xml +++ b/Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_upstream.xml @@ -1,6 +1,14 @@ - + + - + Settings for the inclined EM calorimeter. The barrel is filled with liquid argon. Passive material includes lead in the middle and steal on the outside, glued together. @@ -11,7 +19,8 @@ - + + @@ -24,7 +33,7 @@ - + @@ -33,7 +42,7 @@ - + @@ -44,6 +53,11 @@ + + + + + @@ -56,7 +70,7 @@ taking into account the angular projection effect --> - + @@ -66,7 +80,7 @@ - + @@ -74,7 +88,7 @@ - + system:4,cryo:1,type:3,subtype:3,layer:8,module:11,eta:9 @@ -93,11 +107,15 @@ - + + + + + @@ -132,4 +150,4 @@ - \ No newline at end of file + diff --git a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common.xml b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common.xml index 315ec1e7..01d51626 100644 --- a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common.xml +++ b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common.xml @@ -33,6 +33,11 @@ + + + + + @@ -76,6 +81,10 @@ + + + + diff --git a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_calibration.xml b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_calibration.xml index 89cc23b2..b975e1ba 100644 --- a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_calibration.xml +++ b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_calibration.xml @@ -14,10 +14,10 @@ The barrel is filled with liquid argon. Passive material includes lead in the middle and steal on the outside, glued together. Passive plates are inclined by a certain angle from the radial direction. In between of two passive plates there is a readout. - Space between the plane and readout is of trapezoidal shape and filled with liquid argon. + Space between the plate and readout is of trapezoidal shape and filled with liquid argon. + The calorimeter is divided into 0.5 cm layers, making the simulation flexible for the design studies. + Current study considers layer size const in eta: 2cm + 7 x 9cm. Definition of sizes, visualization settings and readout are specified. - This file is used in the calculation of the sampling fraction that corrects energy for the energy depoisted in the absorber. - Calculation of the sampling fraction can be done as both passive and active material is sensitive. @@ -33,6 +33,11 @@ + + + + + @@ -54,13 +59,13 @@ - - system:4,cryo:1,module:11,type:3,subtype:3,layer:8,eta:9 + + system:4,cryo:1,type:3,subtype:3,layer:8,module:11,eta:9 - + system:4,cryo:1,type:3,subtype:3,layer:8,eta:9,phi:10 @@ -71,14 +76,18 @@ - - - - + + + + + + + + - - + + diff --git a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_upstream.xml b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_upstream.xml index febcbfcd..66a77509 100644 --- a/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_upstream.xml +++ b/Detector/DetFCChhECalInclined/compact/FCChh_ECalBarrel_Common_upstream.xml @@ -18,9 +18,6 @@ The calorimeter is divided into 0.5 cm layers, making the simulation flexible for the design studies. Current study considers layer size const in eta: 2cm + 7 x 9cm. Definition of sizes, visualization settings and readout are specified. - This file is used in the calculation of the energy deposited in the upstream material (cryostat in front of the detector). - Cryostat volume can be distinguished by ID: 'cryostat'==1 and 'type'==1 (cryo front) or 2 (cryo back) or 3 (cryo sides) - or 4 (LAr bath front) or 5 (LAr bath back). @@ -36,6 +33,11 @@ + + + + + @@ -57,13 +59,13 @@ - - system:4,cryo:1,module:11,type:3,subtype:3,layer:8,eta:9 + + system:4,cryo:1,type:3,subtype:3,layer:8,module:11,eta:9 - + system:4,cryo:1,type:3,subtype:3,layer:8,eta:9,phi:10 @@ -74,14 +76,18 @@ - - - - + + + + + + + + - - + + diff --git a/Detector/DetFCChhECalInclined/src/ECalBarrelInclined_geo.cpp b/Detector/DetFCChhECalInclined/src/ECalBarrelInclined_geo.cpp index 51178159..d378a0a4 100644 --- a/Detector/DetFCChhECalInclined/src/ECalBarrelInclined_geo.cpp +++ b/Detector/DetFCChhECalInclined/src/ECalBarrelInclined_geo.cpp @@ -105,8 +105,10 @@ static dd4hep::detail::Ref_t createECalBarrelInclined(dd4hep::Detector& aLcdd, double passiveThickness = passiveInnerThicknessMin + passiveOuterThickness + passiveGlueThickness; double angle = passive.rotation().angle(); - double bathRmin = caloDim.rmin(); // - margin for inclination - double bathRmax = caloDim.rmax(); // + margin for inclination + dd4hep::xml::DetElement bath = aXmlElement.child(_Unicode(bath)); + dd4hep::xml::Dimension bathDim(bath.dimensions()); + double bathRmin = bathDim.rmin(); + double bathRmax = bathDim.rmax(); dd4hep::Tube bathOuterShape(bathRmin, bathRmax, caloDim.dz()); // make it 4 volumes + 5th for detector envelope dd4hep::Tube bathAndServicesOuterShape(cryoDim.rmin2(), cryoDim.rmax1(), caloDim.dz()); // make it 4 volumes + 5th for detector envelope if (cryoThicknessFront > 0) {