Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IBM POWER long double conversions #5108

Open
derobins opened this issue Nov 14, 2024 · 1 comment
Open

Fix IBM POWER long double conversions #5108

derobins opened this issue Nov 14, 2024 · 1 comment
Assignees
@derobins @jhendersonHDF
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Milestone
2.0.0

Comments

@derobins
Copy link
Member

These conversions have been ifdef'd around for years. We need to fix the conversion routines.
@derobins derobins added Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality labels Nov 14, 2024
@derobins derobins added this to the 2.0.0 milestone Nov 14, 2024
@jhendersonHDF
Copy link
Collaborator

The main issue with these conversions is that the library's infrastructure for detecting endian-ness, floating-point field bit positions, etc. assumes that the long double type has a single set of fields (sign, exponent, mantissa), but the IBM long double type has two sets of these fields. The macros and functions in src/H5detect.c will need to be updated to deal with this and some API functions will need to be revised for this type (notably, H5Tget_fields/H5Tset_fields and others in src/H5Tfloat.c, as well as other H5Txxx.c files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derobins derobins

@jhendersonHDF jhendersonHDF

Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@derobins @jhendersonHDF