This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Change the plasma module so that it's statically analysable #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Mar 16, 2020
|
Amended. |
|
I missed converting the |
|
Removed line ending changes, moved change to #123 |
|
Todo before this is merged: check for any naughty assumptions in plPythonPack and verify that packed python works after repacking with this. |
|
This will probably be deferred until we're on Python 3, as we may want to use stub files for the plasma module. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which provides code linting etc.
I added
plasma/__init__.pywhich exposes all the contents of the files inplasma/that were imported separately before. All imports have been changed tofrom plasma import *. For now I changedPlasma.pytoPlasmaStubs.pyto not conflict with the engine's Plasma module. Hoikas proposed changing the engine's module instead, to_Plasma(I didn't do that because I don't have engine development set up).I also changed the Plasma stubs to
raise NotImplementedError(), further improving code linting.