Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflections in Kadish puddles are using env maps for Vault vase reflections #167

Open
ZarothYe opened this issue Jul 5, 2022 · 4 comments

Comments

@ZarothYe
Copy link
Contributor

ZarothYe commented Jul 5, 2022

Found this some months ago and Briggs helped track down the cause.

Reflections in at least one of the Kadish puddles on the path are using reflections indicating stone/wood surroundings when there is nothing matching that in the environment.

Minkata.Kadish.Puddle.Reflection.mp4

It appears to be using the KdshVaseEnviro_BK.tga file for the cubemap.
image

@EhrenCG
Copy link
Contributor

EhrenCG commented Jul 5, 2022

Actually, that puddle, and the little ponds next to the second scope (the ponds you cannot walk in) use this cubic map texture for the hood which is the same for all six faces:
nb01floorrefl_0 hsmBIG
I am 100% certain of this because I have recognized the barricade and cone of this image in all of the listed bodies of water.

But yeah, the use of these textures has always been rather jarring.

The puddle next to the Nexus book and the puddle going through the broken ring structure appear to use the enviro map of the pillar room instead.

@dpogue
Copy link
Member

dpogue commented Jul 5, 2022

IIRC while doing the macOS/Metal port, it was discovered that one of the Kadish environmaps also has one side that's a different size than all the others. I think it was the vase.

@Deledrius
Copy link
Member

Deledrius commented Jul 5, 2022

But yeah, the use of these textures has always been rather jarring.

I agree. When I first played through Kadish, I strongly considered whether there was a clue in the fact that the puddle's reflection appeared to show me a place that wasn't the cave in which it sat. Given the fake doors already encountered as part of the Age, this wasn't totally unreasonable.

It would be nice to have them fixed to be accurate. :)

@ZarothYe
Copy link
Contributor Author

ZarothYe commented Jul 5, 2022

Actually, that puddle, and the little ponds next to the second scope (the ponds you cannot walk in) use this cubic map texture for the hood which is the same for all six faces: nb01floorrefl_0 hsmBIG I am 100% certain of this because I have recognized the barricade and cone of this image in all of the listed bodies of water.

Oh yes, that's totally it! And I'm glad other people have found these perplexing as well, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants