Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI does not use latest libHSPlasma #89

Open
dpogue opened this issue Dec 29, 2024 · 0 comments
Open

Windows CI does not use latest libHSPlasma #89

dpogue opened this issue Dec 29, 2024 · 0 comments

Comments

@dpogue
Copy link
Member

dpogue commented Dec 29, 2024

For Windows CI, we rely on vcpkg for dependencies, including libHSPlasma, which means we end up grabbing the last tagged version that was added to vcpkg rather than grabbing the latest from git.

For Linux, we clone and build libHSPlasma ourselves as part of the CI process.

My thoughts are:

  1. It would be nice to be consistent and use vcpkg everywhere
  2. We do probably want PlasmaShop using latest libHSPlasma
  3. (as an aside from this particular issue, but in the same vein) It would be nice to have macOS CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant