Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk I/O usage (on disk directly, not process) #304

Closed
GuillaumeGomez opened this issue Apr 15, 2020 · 8 comments
Closed

Add disk I/O usage (on disk directly, not process) #304

GuillaumeGomez opened this issue Apr 15, 2020 · 8 comments

Comments

@GuillaumeGomez
Copy link
Owner

GuillaumeGomez commented Apr 15, 2020

On windows it can be done as follow (from @retep998):

You can query disk performance info for the entire disk and not process specific by using FSCTL_FILESYSTEM_GET_STATISTICS
or FSCTL_FILESYSTEM_GET_STATISTICS_EX if you're on windows 10

On linux, it can be retrieved from /proc/diskstats.

@WilliamVenner
Copy link
Contributor

#683

@ClementTsang
Copy link
Contributor

Is there still interest in this? I'm currently doing some work on implementing it for Linux/macOS/Windows https://github.com/ClementTsang/bottom anyways, so I can port over some of that code if you want.

My only question is whether we also need implementations/dummy implementations for the other supported OSes.

@GuillaumeGomez
Copy link
Owner Author

I'm definitely interested. From what you wrote, you don't plan to add FreeBSD but it's fine, I can add the missing parts.

@samin-cf
Copy link
Contributor

Any plans to add this in the short term?

@GuillaumeGomez
Copy link
Owner Author

Unless someone steps up and does it, no. I'm too busy to be able to look into implementing this feature.

@samin-cf
Copy link
Contributor

Sounds good, I will try to put a PR in a few days.

@GuillaumeGomez
Copy link
Owner Author

Awesome, thanks!

@GuillaumeGomez
Copy link
Owner Author

It's now done. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants