Gracefully stop scheduler

[ToshY]

Situation

Currently I'm using scheduler as separate service in my docker compose setup. All my scheduled tasks are send to the message queue. Consuming the messages is also done in a separate service.

# docker-compose.yml
version: '3.9'

services:
  phpfpm:
    extends:
      file: common-services.yml
      service: php-base
    restart: always

  messenger:
    extends:
      file: common-services.yml
      service: php-base
    depends_on:
      - rabbitmq
    restart: 'no'
    command: bin/console messenger:consume -vv async

  schedule:
    extends:
      file: common-services.yml
      service: php-base
    depends_on:
      - rabbitmq
    restart: 'no'
    command: bin/console scheduler:consume --wait --force -vv

Messenger has a command called messenger:stop-workers, which will gracefully stop workers by completing the currently handled messages and then stops further consuming. This is nice as I can send this command to the messenger container, poll the status of the container for status exited, and know it has completely stopped (and continue with deployment) without the actual need of stopping the container using docker compose stop.

Now for the schedule service, I'm running the consume command with --wait --force, which keeps the container alive and waits for new tasks to be handled (similar kind of behavior as the messenger service). Currently, as there is no native command for scheduler to stop (like at messenger), I am forced to stop the container directly.

Question

Thinking about the above, I got the following questions:

• What happens if I stop the container while at the same time a scheduled task would be started/running/active?
• Is it possible/useful to implement a graceful stop command like in messenger?

[Guikingone]

Hi @ToshY 👋🏻

I agree on the fact that SchedulerBundle can benefit from this type of feature, this is not planned in the current roadmap for 0.10 but if you want to work on it, feel free to, I'm going to open an issue related to this discussion, this way, we can track the development of it 🙂

[Guikingone]

Issue #295

[ToshY]

Hey @Guikingone 👋

Good to know that you also think it could be a beneficial feature. While I cannot make any promises at the moment to start working on it myself, maybe I'll give it a shot in the near future.

Thanks for the quick response 😄

[Guikingone]

Hi @ToshY 👋🏻

The StopWorkerCommand has been merged into main, it will be released in 0.10 🙂

Src: https://github.com/Guikingone/SchedulerBundle/blob/main/src/Command/StopWorkerCommand.php

[ToshY]

Hey @Guikingone

Really nice (and fast too) 😄

Thanks and keep up the good work 👍