refactor: collecting memory usage during scan #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
reviewed
Sep 11, 2023
waynexia
reviewed
Sep 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2353 +/- ##
===========================================
- Coverage 85.13% 84.78% -0.35%
===========================================
Files 715 716 +1
Lines 117560 117592 +32
===========================================
- Hits 100082 99705 -377
- Misses 17478 17887 +409 |
|
@sunng87 PTAL |
sunng87
reviewed
Sep 12, 2023
sunng87
approved these changes
Sep 12, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: try custom metrics * chore: fix header * chore: minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This pr mainly replaces
BaselineMetricsto a customized metrics struct in order to hold memory usage during scan plan, indicating the returning size of the dataset to the corresponding query request.Checklist
Refer to a related PR or issue link (optional)