Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify setting the options for the object store's http client #4907

Open
MichaelScofield opened this issue Oct 30, 2024 · 2 comments
Open

Unify setting the options for the object store's http client #4907

MichaelScofield opened this issue Oct 30, 2024 · 2 comments
Labels
C-enhancement Category Enhancements
Milestone

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Configuration

What does the enhancement do?

Now the options for the object store's http client are set like this:

let connect_timeout = env::var("_GREPTIMEDB_HTTP_CONNECT_TIMEOUT")
    .ok()
    .and_then(|v| v.parse::<u64>().ok())
    .unwrap_or(30);
builder = builder.connect_timeout(Duration::from_secs(connect_timeout));

It's better to make them set from the config file instead, like this:

[[storage.providers]]
name = "S3"
type = "S3"
timeout = "30s"
# ...

Implementation challenges

No response

@MichaelScofield MichaelScofield added the C-enhancement Category Enhancements label Oct 30, 2024
@CookiePieWw
Copy link
Collaborator

As we introduced settings for http clients in #5041, we can close this?

@evenyag
Copy link
Contributor

evenyag commented Dec 4, 2024

@MichaelScofield Maybe we can remove the env options in the next release.

@CookiePieWw We can keep this open to remind us to remove them.

@evenyag evenyag added this to the v0.11 milestone Dec 4, 2024
@fengjiachun fengjiachun modified the milestones: v0.11, v0.12 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

4 participants