Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TLS reloading on gRPC server #4104

Open
shuiyisong opened this issue Jun 4, 2024 · 4 comments
Open

Support TLS reloading on gRPC server #4104

shuiyisong opened this issue Jun 4, 2024 · 4 comments
Labels
C-enhancement Category Enhancements

Comments

@shuiyisong
Copy link
Contributor

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

previous: #3336

We've support configuring TLS on gRPC server, but the auto reload is not supported yet, and it's inconsistency with MySQL and PostgreSQL server.

if tls_option.watch {
return Err(Error::NotSupported {
feat: "Certificates watch and reloading for gRPC is not supported at the moment"
.to_string(),
});
}

Let's enable auto reloading on gRPC server too.

Implementation challenges

No response

@shuiyisong shuiyisong added C-enhancement Category Enhancements good first issue Good for newcomers labels Jun 4, 2024
@irenjj
Copy link
Collaborator

irenjj commented Jun 4, 2024

I'd like to take it.

@shuiyisong
Copy link
Contributor Author

I'd like to take it.

Have fun 🤩

@irenjj
Copy link
Collaborator

irenjj commented Jun 9, 2024

hi, @shuiyisong , it seems for tonic based gRPC, reloading TLS config requires restarting the service

@shuiyisong shuiyisong removed the good first issue Good for newcomers label Jun 11, 2024
@shuiyisong
Copy link
Contributor Author

shuiyisong commented Jun 11, 2024

@irenjj OK, it's more complicated then I originally thought. We'll dig into this problem later. Removing you from assignees from now, but you are always free to explore this problem. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

2 participants