You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we use the default option of curl to download dashboard assets. It's possible suffering network issue and timeout after a relatively long time.
We'd better improve the retry strategy (e.g., retry times, shorter retry interval) and prompt the suggestion to use GHPROXY if users do not configure it (or http_proxy that curl would respect, I don't determinate a good suggestion prompt here).
Implementation challenges
If we keep using shell (bash), we can add a function to do the retry. Or even we can rewrite the script with Python so it's more programmatic
The text was updated successfully, but these errors were encountered:
What type of enhancement is this?
Other
What does the enhancement do?
greptimedb/scripts/fetch-dashboard-assets.sh
Lines 23 to 29 in e481f07
Currently, we use the default option of
curl
to download dashboard assets. It's possible suffering network issue and timeout after a relatively long time.We'd better improve the retry strategy (e.g., retry times, shorter retry interval) and prompt the suggestion to use GHPROXY if users do not configure it (or http_proxy that curl would respect, I don't determinate a good suggestion prompt here).
Implementation challenges
If we keep using shell (bash), we can add a function to do the retry. Or even we can rewrite the script with Python so it's more programmatic
The text was updated successfully, but these errors were encountered: