Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve retry when download assets and prompt proxy suggestion #3382

Closed
tisonkun opened this issue Feb 26, 2024 · 0 comments · Fixed by #3394
Closed

Improve retry when download assets and prompt proxy suggestion #3382

tisonkun opened this issue Feb 26, 2024 · 0 comments · Fixed by #3394
Labels
good first issue Good for newcomers

Comments

@tisonkun
Copy link
Collaborator

What type of enhancement is this?

Other

What does the enhancement do?

# Download the SHA256 checksum attached to the release. To verify the integrity
# of the download, this checksum will be used to check the download tar file
# containing the built dashboard assets.
curl -Ls ${GITHUB_URL}/GreptimeTeam/dashboard/releases/download/$RELEASE_VERSION/sha256.txt --output sha256.txt
# Download the tar file containing the built dashboard assets.
curl -L ${GITHUB_URL}/GreptimeTeam/dashboard/releases/download/$RELEASE_VERSION/build.tar.gz --output build.tar.gz

Currently, we use the default option of curl to download dashboard assets. It's possible suffering network issue and timeout after a relatively long time.

We'd better improve the retry strategy (e.g., retry times, shorter retry interval) and prompt the suggestion to use GHPROXY if users do not configure it (or http_proxy that curl would respect, I don't determinate a good suggestion prompt here).

Implementation challenges

If we keep using shell (bash), we can add a function to do the retry. Or even we can rewrite the script with Python so it's more programmatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant