Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected trim behavior of join_path #3212

Closed
v0y4g3r opened this issue Jan 22, 2024 · 4 comments · Fixed by #3280
Closed

Unexpected trim behavior of join_path #3212

v0y4g3r opened this issue Jan 22, 2024 · 4 comments · Fixed by #3280
Assignees
Labels
C-bug Category Bugs good first issue Good for newcomers

Comments

@v0y4g3r
Copy link
Contributor

v0y4g3r commented Jan 22, 2024

join_path function will trim leading / in path. So when joining /a/b with c, the resulting path will be a/b/c instead of /a/b/c


          > Use join_path?

join_path does not apply here since it removes leading / in path:

opendal::raw::normalize_path(&output)

Originally posted by @v0y4g3r in #3164 (comment)

@v0y4g3r v0y4g3r added C-bug Category Bugs good first issue Good for newcomers labels Jan 22, 2024
@erichengber
Copy link

Hi I am an undergraduate at the University of Florida looking for my first contribution and this seems like something I can do. Mind if I give it a try?

@evenyag
Copy link
Contributor

evenyag commented Jan 25, 2024

Sure, you could implement a new normalize_path() function based on OpenDAL's normalize_path() and modify its default behavior.

@dalprahcd
Copy link
Contributor

Hello @erichengber, are you still working on this issue?

@tisonkun
Copy link
Collaborator

tisonkun commented Feb 4, 2024

Hi @dalprahcd!

As @erichengber doesn't share more progress for about a week and has no patch yet, you can start to work on it and submit a patch. Feel free to ping me as a reviewer and I'll switch the assignee when a patch is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category Bugs good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants