Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring heartbeat status #2848

Open
MichaelScofield opened this issue Nov 30, 2023 · 1 comment
Open

Monitoring heartbeat status #2848

MichaelScofield opened this issue Nov 30, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Tech debt reduction

What does the enhancement do?

Heartbeat plays a critical role in our system. However, we are lacking of the ability to monitor the status of it. It's useful because through the lens of heartbeat monitoring, one could tell whether the network between Datanode/Frontend and Metasrv is healthy, or understand the actions Metasrv does by deriving from dealing with the heartbeat's payload data. Very helpful for database maintainer.

So I propose adding the following prometheus metrics:

  • Heartbeat request send count in Datanode and Frontend
  • Heartbeat response receive count in Datanode and Frontend, labelled with response types
  • Metasrv heartbeat receive count, labelled with pusher key

Implementation challenges

No response

@MichaelScofield MichaelScofield added the good first issue Good for newcomers label Nov 30, 2023
@killme2008 killme2008 added the help wanted Extra attention is needed label Jan 2, 2024
@killme2008
Copy link
Contributor

We need some docs to describe how to add these metrics and where to add them. @MichaelScofield

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants