Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up the starting of datanode #2774

Closed
WenyXu opened this issue Nov 20, 2023 · 2 comments
Closed

Speed up the starting of datanode #2774

WenyXu opened this issue Nov 20, 2023 · 2 comments
Labels
C-enhancement Category Enhancements

Comments

@WenyXu
Copy link
Member

WenyXu commented Nov 20, 2023

What type of enhancement is this?

User experience

What does the enhancement do?

Opening a region in mito2 still waits for network returns in a &mut self function, which is super expensive.(If opening a region requires 50ms, this worker only has 20qps)

let region = RegionOpener::new(
region_id,
&request.region_dir,
self.memtable_builder.clone(),
self.object_store_manager.clone(),
self.scheduler.clone(),
)
.options(request.options)
.cache(Some(self.cache_manager.clone()))
.open(&self.config, &self.wal)
.await?;

Implementation challenges

No response

@WenyXu WenyXu added the C-enhancement Category Enhancements label Nov 20, 2023
@tisonkun
Copy link
Collaborator

Is this issue still relevant? It seems quite vague what we can improve.

@tisonkun
Copy link
Collaborator

Closed unless we have more concrete stuff to improve.

@tisonkun tisonkun closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

2 participants