We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try_flush
Refactor, Tech debt reduction
Remove the redundant try_flush invoking, it's already invoked in write. And remove the pub visitability for try_flush.
write
pub
greptimedb/src/mito2/src/sst/stream_writer.rs
Lines 86 to 93 in 102e4c9
No response
The text was updated successfully, but these errors were encountered:
Please assign this to me
Sorry, something went wrong.
@Abhishek-Mallick Just a kind reminder, are u still working on this issue? Happy New Year!
Hey @killme2008 Happy 2024! Sorry was a bit late Yes I'll work on this right away
Successfully merging a pull request may close this issue.
What type of enhancement is this?
Refactor, Tech debt reduction
What does the enhancement do?
Remove the redundant
try_flush
invoking, it's already invoked inwrite
. And remove thepub
visitability fortry_flush
.greptimedb/src/mito2/src/sst/stream_writer.rs
Lines 86 to 93 in 102e4c9
Implementation challenges
No response
The text was updated successfully, but these errors were encountered: