Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant try_flush invoking #2657

Closed
WenyXu opened this issue Oct 26, 2023 · 3 comments · Fixed by #3706
Closed

Remove redundant try_flush invoking #2657

WenyXu opened this issue Oct 26, 2023 · 3 comments · Fixed by #3706
Labels
C-enhancement Category Enhancements

Comments

@WenyXu
Copy link
Member

WenyXu commented Oct 26, 2023

What type of enhancement is this?

Refactor, Tech debt reduction

What does the enhancement do?

Remove the redundant try_flush invoking, it's already invoked in write. And remove the pub visitability for try_flush.

self.inner
.write(arrow_batch)
.await
.context(error::WriteBufferSnafu)?;
self.inner
.try_flush(false)
.await
.context(error::WriteBufferSnafu)?;

Implementation challenges

No response

@WenyXu WenyXu added the C-enhancement Category Enhancements label Oct 26, 2023
@Abhishek-Mallick
Copy link

Please assign this to me

@killme2008
Copy link
Contributor

@Abhishek-Mallick Just a kind reminder, are u still working on this issue? Happy New Year!

@Abhishek-Mallick
Copy link

Hey @killme2008 Happy 2024!
Sorry was a bit late
Yes I'll work on this right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants