diff --git a/docker/dev-builder/ubuntu/Dockerfile b/docker/dev-builder/ubuntu/Dockerfile index 8f07b5a87bb6..d78603234e43 100644 --- a/docker/dev-builder/ubuntu/Dockerfile +++ b/docker/dev-builder/ubuntu/Dockerfile @@ -1,5 +1,8 @@ FROM ubuntu:20.04 +# The root path under which contains all the dependencies to build this Dockerfile. +ARG DOCKER_BUILD_ROOT=. + ENV LANG en_US.utf8 WORKDIR /greptimedb @@ -27,10 +30,20 @@ RUN apt-get -y purge python3.8 && \ ln -s /usr/bin/python3.10 /usr/bin/python3 && \ curl -sS https://bootstrap.pypa.io/get-pip.py | python3.10 -RUN git config --global --add safe.directory /greptimedb +# Silence all `safe.directory` warnings, to avoid the "detect dubious repository" error when building with submodules. +# Disabling the safe directory check here won't pose extra security issues, because in our usage for this dev build +# image, we use it solely on our own environment (that github action's VM, or ECS created dynamically by ourselves), +# and the repositories are pulled from trusted sources (still us, of course). Doing so does not violate the intention +# of the Git's addition to the "safe.directory" at the first place (see the commit message here: +# https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9). +# There's also another solution to this, that we add the desired submodules to the safe directory, instead of using +# wildcard here. However, that requires the git's config files and the submodules all owned by the very same user. +# It's troublesome to do this since the dev build runs in Docker, which is under user "root"; while outside the Docker, +# it can be a different user that have prepared the submodules. +RUN git config --global --add safe.directory ‘*’ # Install Python dependencies. -COPY ./docker/python/requirements.txt /etc/greptime/requirements.txt +COPY $DOCKER_BUILD_ROOT/docker/python/requirements.txt /etc/greptime/requirements.txt RUN python3 -m pip install -r /etc/greptime/requirements.txt # Install Rust.