From 533ada70ca2fb9f07358cccb3de2ba51892af694 Mon Sep 17 00:00:00 2001
From: discord9 <55937128+discord9@users.noreply.github.com>
Date: Mon, 20 May 2024 16:34:47 +0800
Subject: [PATCH] chore: remove a dbg! forget to remove (#3990)

* chore: remove a dbg! forget to remove

* remove other dbg! and add lint

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* fix pyo3 feature

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
---
 Cargo.toml                                      |  1 +
 src/flow/src/expr/scalar.rs                     |  2 +-
 src/script/src/python/ffi_types/pair_tests.rs   | 14 +-------------
 src/script/src/python/pyo3/copr_impl.rs         |  1 -
 src/script/src/python/rspython/builtins/test.rs |  1 -
 src/script/src/python/rspython/test.rs          |  9 ---------
 6 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index f0cf8265be06..8390a4f0f710 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -71,6 +71,7 @@ license = "Apache-2.0"
 [workspace.lints]
 clippy.print_stdout = "warn"
 clippy.print_stderr = "warn"
+clippy.dbg_macro = "warn"
 clippy.implicit_clone = "warn"
 clippy.readonly_write_lock = "allow"
 rust.unknown_lints = "deny"
diff --git a/src/flow/src/expr/scalar.rs b/src/flow/src/expr/scalar.rs
index 53c570e7a6c2..dfd5fcd0f214 100644
--- a/src/flow/src/expr/scalar.rs
+++ b/src/flow/src/expr/scalar.rs
@@ -106,7 +106,7 @@ impl TypedExpr {
             })
             .collect::<Result<Vec<_>, _>>()?;
 
-        Ok(dbg!(exprs))
+        Ok(exprs)
     }
 }
 
diff --git a/src/script/src/python/ffi_types/pair_tests.rs b/src/script/src/python/ffi_types/pair_tests.rs
index 781bae9b9e61..3b48fc40319d 100644
--- a/src/script/src/python/ffi_types/pair_tests.rs
+++ b/src/script/src/python/ffi_types/pair_tests.rs
@@ -166,18 +166,10 @@ fn eval_rspy(case: CodeBlockTestCase) {
         }
         let code_obj = vm
             .compile(&case.script, Mode::BlockExpr, "<embedded>".to_owned())
-            .map_err(|err| {
-                dbg!(&err);
-                vm.new_syntax_error(&err)
-            })
+            .map_err(|err| vm.new_syntax_error(&err))
             .unwrap();
         let result_vector = vm
             .run_code_obj(code_obj, scope)
-            .map_err(|e| {
-                dbg!(&e);
-                dbg!(&case.script);
-                e
-            })
             .unwrap()
             .downcast::<PyVector>()
             .unwrap();
@@ -211,10 +203,6 @@ fn eval_pyo3(case: CodeBlockTestCase) {
             .unwrap()
             .unwrap()
             .extract::<PyVector>()
-            .map_err(|e| {
-                dbg!(&case.script);
-                e
-            })
             .unwrap();
         if !check_equal(res_vec.as_vector_ref(), case.expect.clone()) {
             panic!(
diff --git a/src/script/src/python/pyo3/copr_impl.rs b/src/script/src/python/pyo3/copr_impl.rs
index 2dbd574827ae..4ee56021e1f0 100644
--- a/src/script/src/python/pyo3/copr_impl.rs
+++ b/src/script/src/python/pyo3/copr_impl.rs
@@ -349,7 +349,6 @@ def a(cpu, mem, **kwargs):
             &HashMap::from([("a".to_string(), "1".to_string())]),
             &EvalContext::default(),
         );
-        dbg!(&ret);
         let _ = ret.unwrap();
     }
 }
diff --git a/src/script/src/python/rspython/builtins/test.rs b/src/script/src/python/rspython/builtins/test.rs
index 3a5ea2115b97..f7b9c851e069 100644
--- a/src/script/src/python/rspython/builtins/test.rs
+++ b/src/script/src/python/rspython/builtins/test.rs
@@ -455,7 +455,6 @@ sin(values)"#,
             }
             Ok(obj) => {
                 let _ser = PyValue::from_py_obj(&obj, vm);
-                dbg!(_ser);
             }
         }
     });
diff --git a/src/script/src/python/rspython/test.rs b/src/script/src/python/rspython/test.rs
index 310c32f798d8..86584d48094e 100644
--- a/src/script/src/python/rspython/test.rs
+++ b/src/script/src/python/rspython/test.rs
@@ -184,7 +184,6 @@ def a(cpu, mem: vector[f64])->(vector[f64|None], vector[f64], vector[_], vector[
 "#;
     let pyast = parse(python_source, Mode::Interactive, "<embedded>").unwrap();
     let copr = parse_and_compile_copr(python_source, None);
-    dbg!(copr);
 }
 
 #[test]
@@ -265,10 +264,6 @@ def calc_rvs(open_time, close):
             "copr.py",
         );
         info!("{res}");
-    } else if let Ok(res) = ret {
-        dbg!(&res);
-    } else {
-        dbg!(ret);
     }
 }
 
@@ -311,9 +306,5 @@ def a(cpu, mem):
             "copr.py",
         );
         info!("{res}");
-    } else if let Ok(res) = ret {
-        dbg!(&res);
-    } else {
-        dbg!(ret);
     }
 }