From 4fe7e162af000f198df5bcca0ef350c4442f4fd9 Mon Sep 17 00:00:00 2001
From: Wei <47681251+QuenKar@users.noreply.github.com>
Date: Tue, 10 Oct 2023 15:22:12 +0800
Subject: [PATCH] fix: human_time mismatch (#2558)

* fix: human_time mismatch.

* fix: add comment
---
 src/common/time/src/datetime.rs              | 8 ++++++--
 src/meta-srv/src/service/admin/node_lease.rs | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/common/time/src/datetime.rs b/src/common/time/src/datetime.rs
index 39f451db8e11..451dc57cf7ed 100644
--- a/src/common/time/src/datetime.rs
+++ b/src/common/time/src/datetime.rs
@@ -93,18 +93,22 @@ impl From<Date> for DateTime {
 }
 
 impl DateTime {
-    pub fn new(val: i64) -> Self {
-        Self(val)
+    /// Create a new [DateTime] from milliseconds elapsed since "1970-01-01 00:00:00 UTC" (UNIX Epoch).
+    pub fn new(millis: i64) -> Self {
+        Self(millis)
     }
 
+    /// Get the milliseconds elapsed since "1970-01-01 00:00:00 UTC" (UNIX Epoch).
     pub fn val(&self) -> i64 {
         self.0
     }
 
+    /// Convert to [NaiveDateTime].
     pub fn to_chrono_datetime(&self) -> Option<NaiveDateTime> {
         NaiveDateTime::from_timestamp_millis(self.0)
     }
 
+    /// Convert to [common_time::date].
     pub fn to_date(&self) -> Option<Date> {
         self.to_chrono_datetime().map(|d| Date::from(d.date()))
     }
diff --git a/src/meta-srv/src/service/admin/node_lease.rs b/src/meta-srv/src/service/admin/node_lease.rs
index 3655cd3aae11..4b94674a25eb 100644
--- a/src/meta-srv/src/service/admin/node_lease.rs
+++ b/src/meta-srv/src/service/admin/node_lease.rs
@@ -43,7 +43,7 @@ impl HttpHandler for NodeLeaseHandler {
             .into_iter()
             .map(|(k, v)| HumanLease {
                 name: k,
-                human_time: common_time::DateTime::new(v.timestamp_millis / 1000).to_string(),
+                human_time: common_time::DateTime::new(v.timestamp_millis).to_string(),
                 lease: v,
             })
             .collect::<Vec<_>>();