From 2b6ef9d405846049d8ea32eeab40f5a6f29b95e4 Mon Sep 17 00:00:00 2001 From: Ruihang Xia Date: Fri, 3 Nov 2023 10:38:23 +0800 Subject: [PATCH] apply review sugg Signed-off-by: Ruihang Xia --- src/metric-engine/src/engine.rs | 8 +------- src/mito2/src/engine.rs | 3 +-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/metric-engine/src/engine.rs b/src/metric-engine/src/engine.rs index 456ded4d4bfe..0262c3255843 100644 --- a/src/metric-engine/src/engine.rs +++ b/src/metric-engine/src/engine.rs @@ -42,7 +42,7 @@ pub const METRIC_DATA_REGION_GROUP: RegionGroup = 0; pub const METRIC_METADATA_REGION_GROUP: RegionGroup = 1; const METADATA_SCHEMA_TIMESTAMP_COLUMN_NAME: &str = "ts"; -const METADATA_SCHEMA_KEY_COLUMN_NAME: &str = "key"; +const METADATA_SCHEMA_KEY_COLUMN_NAME: &str = "k"; const METADATA_SCHEMA_VALUE_COLUMN_NAME: &str = "val"; const METADATA_REGION_SUBDIR: &str = "metadata"; @@ -282,7 +282,6 @@ mod test { inner: Arc::new(MetricEngineInner { mito }), }; let engine_dir = env.data_home(); - info!("[DEBUG] {engine_dir}"); let region_dir = join_dir(&engine_dir, "test_metric_region"); let region_id = RegionId::new(1, 2); @@ -300,11 +299,6 @@ mod test { .await .unwrap(); - let mut ls_result = tokio::fs::read_dir(&engine_dir).await.unwrap(); - while let Some(dir) = ls_result.next_entry().await.unwrap() { - info!("[DEBUG] {dir:?}"); - } - // assert metadata region's dir let metadata_region_dir = join_dir(®ion_dir, METADATA_REGION_SUBDIR); let exist = tokio::fs::try_exists(region_dir).await.unwrap(); diff --git a/src/mito2/src/engine.rs b/src/mito2/src/engine.rs index a10a7ce9aee8..3115cb180d5d 100644 --- a/src/mito2/src/engine.rs +++ b/src/mito2/src/engine.rs @@ -29,8 +29,7 @@ mod drop_test; #[cfg(test)] mod flush_test; #[cfg(any(test, feature = "test"))] -#[cfg_attr(feature = "test", allow(unused))] -pub(crate) mod listener; +pub mod listener; #[cfg(test)] mod open_test; #[cfg(test)]