From 1cd4af2fff8e9c41c69dc974cff99bcb0eed2996 Mon Sep 17 00:00:00 2001 From: shuiyisong Date: Sun, 8 Oct 2023 16:53:36 +0800 Subject: [PATCH] chore: modify comments --- src/auth/Cargo.toml | 2 -- src/frontend/src/instance.rs | 2 -- src/partition/Cargo.toml | 2 -- src/plugins/Cargo.toml | 2 -- src/plugins/src/lib.rs | 2 ++ 5 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/auth/Cargo.toml b/src/auth/Cargo.toml index 3909d8078157..748da3b40f8b 100644 --- a/src/auth/Cargo.toml +++ b/src/auth/Cargo.toml @@ -4,8 +4,6 @@ version.workspace = true edition.workspace = true license.workspace = true -# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html - [features] default = [] testing = [] diff --git a/src/frontend/src/instance.rs b/src/frontend/src/instance.rs index f663e22a51b8..aff95a9d68fb 100644 --- a/src/frontend/src/instance.rs +++ b/src/frontend/src/instance.rs @@ -122,8 +122,6 @@ pub struct Instance { script_executor: Arc, statement_executor: Arc, query_engine: QueryEngineRef, - /// plugins: this map holds extensions to customize query or auth - /// behaviours. plugins: PluginsRef, servers: Arc, heartbeat_task: Option, diff --git a/src/partition/Cargo.toml b/src/partition/Cargo.toml index 4cb2def7bf88..e56b1d6df952 100644 --- a/src/partition/Cargo.toml +++ b/src/partition/Cargo.toml @@ -4,8 +4,6 @@ version.workspace = true edition.workspace = true license.workspace = true -# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html - [dependencies] api = { workspace = true } async-trait = "0.1" diff --git a/src/plugins/Cargo.toml b/src/plugins/Cargo.toml index 5d91bf13dede..a11150f7f34e 100644 --- a/src/plugins/Cargo.toml +++ b/src/plugins/Cargo.toml @@ -4,8 +4,6 @@ version.workspace = true edition.workspace = true license.workspace = true -# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html - [dependencies] auth.workspace = true common-base.workspace = true diff --git a/src/plugins/src/lib.rs b/src/plugins/src/lib.rs index 3bf9c0fb2bac..2712147ac700 100644 --- a/src/plugins/src/lib.rs +++ b/src/plugins/src/lib.rs @@ -21,6 +21,8 @@ pub use datanode::{setup_datanode_plugins, start_datanode_plugins}; pub use frontend::{setup_frontend_plugins, start_frontend_plugins}; pub use meta_srv::{setup_meta_srv_plugins, start_meta_srv_plugins}; +/// [`OptPlugins`] is a wrapper around [`PluginsRef`] and opts returned by setup functions. +/// T can be [`DatanodeOptions`], [`FrontendOptions`] or [`MetaSrvOptions`]. pub struct OptPlugins { pub opts: T, pub plugins: PluginsRef,