Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Buttons from chapter to chapter / book to book #4

Open
2 tasks
GregCM opened this issue Oct 21, 2020 · 1 comment
Open
2 tasks

Navigation Buttons from chapter to chapter / book to book #4

GregCM opened this issue Oct 21, 2020 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@GregCM
Copy link
Owner

GregCM commented Oct 21, 2020

Bug

A whole book-search results in latency and potential crash upon scrolling through many lines of text.

Solution

Consider the BLB search results for Genesis, specifically the button layout below

Issue4

where a single arrow goes forward or back one(1) chapter, and a double arrow goes forward or back one(1) book, alongside a dropdown of book options

Files in Question

  • handler
  • __init__
@GregCM GregCM added bug Something isn't working enhancement New feature or request labels Oct 21, 2020
@GregCM GregCM self-assigned this Oct 21, 2020
@GregCM
Copy link
Owner Author

GregCM commented Oct 26, 2020

Since latency in lengthy books will be an issue as long as tkinter or other ui is in use (and since whole-book searches are really less than ideal for all but a very few short books)... the best choice is to forego the double-arrow idea and replace it with a dynamic single arrow. Ergo, if I have in view a Verse, I want to show the next or previous verse with a click; if I have a chapter, show the next or previous chapter. The result of this structural change will be that any whole-book searches, ie "Genesis" will only return the first chapter, but will be much easier to navigate through (sidenote: it may still be valuable to save an entire book, but this doesn't have to be TextWidget dependen).

Additional Feature Idea: If I have in view a Verse, it would be much less anti-climactic to show the previous and next verses before the actual search item. Navigating rightwards will "scroll" to the next visible verse, rid the leading context verse, and add a the next trailing context verse.

This is especially valuable in a single result search, where there's nothing to look at but one verse, maybe 10 words long, no other options, and only a search bar to direct my thoughts.

  • Chapters
    • Up/Down within a book
    • Up to previous book (final chapter)
    • Down to next book (first chapter)
  • Verses
    • Up/Down within a chapter
    • Up to previous chapter/book (final verse)
    • Down to next chapter/book (first verse)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant