Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Issue] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail when using external drive #301

Closed
amurgshere opened this issue Nov 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@amurgshere
Copy link
Contributor

amurgshere commented Nov 23, 2024

Description of the issue

When saving files under Mac OS Sequoia to an external drive not formatted with APFS, a dot underscore attribute file is created for modified files, MSBUILD picks these up and fails the build with error:

CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]

Adding the following line to the csproj files inside the project group will stop these files from attempted to being built:

<DefaultItemExcludes>$(DefaultItemExcludes);._*</DefaultItemExcludes>

Also suggest that we exclude these files from GIT as well by adding this line to the .gitignore file:

._*

Does anybody have an issue with me creating a PR with these changes in them to make development under MacOS Sequoia more pleasant?

Reproduction steps

  1. Using an external drive formatted as exFAT under MacOS Sequoia, modify a code file and save
  2. Notice that a ._ file is created for the modified file with "com.apple.provenance" attribute
  3. Attempt to build, build fails due to binary file

Log file

CSC : error CS2015: '/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/._Updater.cs' is a binary file instead of a text file [/Volumes/MACBOOK/EXEC/Ryujinx/GitHub/Ryujinx/src/Ryujinx/Ryujinx.csproj]

OS

Mac OS Sequoia 15.1

Ryujinx version

All

Game version

NA

CPU

NA

GPU

NA

RAM

NA

List of applied mods

No response

Additional context?

No response

@amurgshere amurgshere added the bug Something isn't working label Nov 23, 2024
@amurgshere amurgshere changed the title [Bug] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail [Build Issue] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail Nov 23, 2024
@GreemDev
Copy link
Owner

You're one of the only people who could open a PR to fix this, as I don't have a mac. So you probably should

@amurgshere amurgshere changed the title [Build Issue] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail [Build Issue] MacOS Sequoia Creates dot underscore files for com.apple.provenance which cause build to fail when using external drive Nov 23, 2024
@amurgshere
Copy link
Contributor Author

Hey @GreemDev , I have created PR #302 to fix this, thank you.

@GreemDev
Copy link
Owner

GreemDev commented Dec 6, 2024

PR for this was merged a while ago, I guess it was never linked to this issue. Closing

@GreemDev GreemDev closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants