Add auto refresh button to events page #20996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
reviewed
Nov 26, 2024
| import useSearchConfiguration from 'hooks/useSearchConfiguration'; | ||
| import useMinimumRefreshInterval from 'views/hooks/useMinimumRefreshInterval'; | ||
|
|
||
| export const durationToMS = (duration: string) => moment.duration(duration).asMilliseconds(); |
There was a problem hiding this comment.
This would be a good addition to the DateTime utils. It would be nice to add a comment with an example input.
| humanName: string, | ||
| } | ||
|
|
||
| const CommonRefreshControls = ({ humanName, disable, onToggle = null, onEnable = null, onDisable = null, intervalOptions, onSelectInterval = null, isLoadingMinimumInterval, minimumRefreshInterval, defaultInterval }: Props) => { |
There was a problem hiding this comment.
Since we are already in the common dir, let's just call it RefreshControls? If you want to avoid having two components with the name, you could rename the one in the views directory to ViewsRefreshControls? Similar to how you named EventsRefreshControls.
If we can avoid having the name of the directory in the component name, I would do that for the common refresh controls component.
linuspahl
reviewed
Nov 26, 2024
changelog/unreleased/pr-20996.toml
Outdated
| @@ -0,0 +1,5 @@ | |||
| type = "a" | |||
| message = "Add auto refresh to events page" | |||
There was a problem hiding this comment.
This sounds like the events list is now refreshing automatically when you open it.
linuspahl
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactor creates CommonRefreshControls components to reuse most of the logic in RefreshControls components.
Also, we add a refresh action to events page.
Motivation and Context
fix: https://github.com/Graylog2/graylog-plugin-enterprise/issues/8661
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/jpd https://github.com/Graylog2/graylog-plugin-enterprise/pull/9269