Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video transcoding: Muting and trimming collisions #9332

Closed
barklund opened this issue Oct 8, 2021 · 1 comment
Closed

Video transcoding: Muting and trimming collisions #9332

barklund opened this issue Oct 8, 2021 · 1 comment
Labels
Elements: Video Group: Canvas Group: Style Panel Group: Video Optimization Media transcoding, compression and cropping Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Enhancement New feature or improvement of an existing feature

Comments

@barklund
Copy link
Contributor

barklund commented Oct 8, 2021

Feature Description

Currently, we have some situations, where you can end up with a video "un-muting" even though you might not expect it to.

Scenario

  • You have an original non-muted video of 60-second duration
  • You trim the non-muted video to make a non-muted 30-second video
  • You mute that video to make a muted 30-second video
  • You then re-trim that muted 30-second video to a new 45-second video
  • You might expect this new 45-second video to also be muted, but it's not, since it has been trimmed from the original non-muted video.

We should figure out which result should be the correct one and implement that.

This arose from a discussion in #9315.

Alternatives Considered

The current approach might be the correct one (the mute flag of the original takes precedence).
@barklund barklund added the Type: Enhancement New feature or improvement of an existing feature label Oct 8, 2021
@swissspidy swissspidy added Group: Style Panel Group: Video Optimization Media transcoding, compression and cropping labels Oct 8, 2021
@barklund barklund added Elements: Video Group: Canvas Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P2 Should do soon labels Oct 8, 2021
@gajasinski
Copy link

IMO if the user has explicitly muted the video, we should carry that throughout the trim experience.

@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels Jan 26, 2023
@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Elements: Video Group: Canvas Group: Style Panel Group: Video Optimization Media transcoding, compression and cropping Group: Workspace A group encompassing all of workspace – everything inside the canvas and sidebar P3 Nice to have Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@barklund @swissspidy @gajasinski