Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Interactivity API for frontend functionality #13502

Open
swissspidy opened this issue Nov 22, 2023 · 4 comments · May be fixed by #13704
Open

Use Interactivity API for frontend functionality #13502

swissspidy opened this issue Nov 22, 2023 · 4 comments · May be fixed by #13704
Labels
Group: Blocks Issues related to the provided Gutenberg Blocks P3 Nice to have Type: Enhancement New feature or improvement of an existing feature Type: Performance Performance related issues and enhancements.

Comments

@swissspidy
Copy link
Collaborator

Feature Description

WordPress 6.4 ships with the Interactivity API, which is an ideal tool for implementing the lightbox functionality in the Web Stories block. SImilar to how the core image block uses it for its lightbox.

Sites using an older WordPress version can still use the existing JS we have.

In the future we could even think about replacing the carousel with the Interactivity API or find other use cases for it.
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Type: Performance Performance related issues and enhancements. Group: Blocks Issues related to the provided Gutenberg Blocks labels Nov 22, 2023
@swissspidy swissspidy added this to the 1.36.0 milestone Nov 22, 2023
@swissspidy
Copy link
Collaborator Author

Related: WordPress/gutenberg#55642

@swissspidy
Copy link
Collaborator Author

As per yesterday's chat: we do quite a few things more than lightbox, so we might still need some custom JS. If it turns out to be more / unnecessarily complex, we can put this on hold for now and focus on other issues instead.

@swissspidy swissspidy removed this from the 1.36.0 milestone Dec 13, 2023
@swissspidy
Copy link
Collaborator Author

Putting this on hold for now as per our discussion. Doesn't seem straightforward to use after all, as our use case is a bit more complex.

@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2023
@swissspidy swissspidy added the P3 Nice to have label Apr 16, 2024
@swissspidy
Copy link
Collaborator Author

The stable version actually landed in WordPress 6.5, so I think we should revisit this.

@swissspidy swissspidy reopened this Apr 16, 2024
@swissspidy swissspidy mentioned this issue Apr 16, 2024
Closed
@swissspidy swissspidy added this to the 1.37.0 milestone May 30, 2024
@Swanand01 Swanand01 linked a pull request May 30, 2024 that will close this issue
Open
7 tasks
@swissspidy swissspidy modified the milestones: 1.37.0, 1.38.0 Jun 17, 2024
@swissspidy swissspidy removed this from the 1.38.0 milestone Jun 25, 2024
@swissspidy swissspidy added the Status: Blocked On hold for the time being label Jul 1, 2024
@swissspidy swissspidy removed the Status: Blocked On hold for the time being label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: Blocks Issues related to the provided Gutenberg Blocks P3 Nice to have Type: Enhancement New feature or improvement of an existing feature Type: Performance Performance related issues and enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Interactivity API for frontend functionality GoogleForCreators/web-stories-wp
1 participant
@swissspidy