Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styled-components to v6 #13419

Closed
swissspidy opened this issue Jul 11, 2023 · 3 comments
Closed

Update styled-components to v6 #13419

swissspidy opened this issue Jul 11, 2023 · 3 comments
Labels
P3 Nice to have Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering

Comments

@swissspidy
Copy link
Collaborator

Task Description

https://styled-components.com/docs/faqs#what-do-i-need-to-do-to-migrate-to-v6
@swissspidy swissspidy added P2 Should do soon Type: Task Tasks which do not involve engineering Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ labels Jul 11, 2023
@swissspidy swissspidy added this to the 1.34.0 milestone Jul 11, 2023
@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels Jul 12, 2023
@swissspidy swissspidy removed this from the 1.34.0 milestone Jul 19, 2023
@swissspidy
Copy link
Collaborator Author

#13443 migrates the activation-notice package

@swissspidy
Copy link
Collaborator Author

I have a local branch where I experimented with this upgrade. There was a lot of noise in the console due to all the DOM pollution. This might take a bit longer to fix.

@swissspidy swissspidy added this to the 1.35.0 milestone Aug 17, 2023
@swissspidy swissspidy removed this from the 1.35.0 milestone Sep 1, 2023
@swissspidy
Copy link
Collaborator Author

This would be such a huge effort, not really worth working on that at the moment

@swissspidy swissspidy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Nice to have Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swissspidy