Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llama2-model.libsonnet to setup env with common.libsonnet #1008

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ManfeiBai
Copy link
Collaborator

@ManfeiBai ManfeiBai commented Oct 20, 2023

Description

Please include a summary of relevant context/issue and your changes.

Tests

Please describe the tests that you ran on TPUs to verify changes.

Instruction and/or command lines to reproduce your tests:
./scripts/run-oneshot.sh -t pt-nightly-llama2-pjrt-train-spmd-func-v4-8-1vm-1vm
./scripts/run-oneshot.sh -t pt-nightly-llama2-pjrt-infer-func-v4-8-1vm-1vm

List links for your tests (use go/shortn-gen for any internal link):
./scripts/run-oneshot.sh -t pt-nightly-llama2-pjrt-train-spmd-func-v4-8-1vm-1vm: http://shortn/_SfQAvt7dbI
./scripts/run-oneshot.sh -t pt-nightly-llama2-pjrt-infer-func-v4-8-1vm-1vm: http://shortn/_StagYnH5nx

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@ManfeiBai ManfeiBai requested a review from vanbasten23 October 20, 2023 18:48
Copy link
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManfeiBai ManfeiBai merged commit 7b38749 into master Oct 20, 2023
16 of 19 checks passed
@ManfeiBai ManfeiBai deleted the ManfeiBai-patch-5 branch October 20, 2023 20:34
@vanbasten23
Copy link
Collaborator

I couldn't see the merge button. So you need to find someone who has the permission to merge it.

@ManfeiBai
Copy link
Collaborator Author

I couldn't see the merge button. So you need to find someone who has the permission to merge it.

thanks, Xiongfei, merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants