Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate options for --input_prefix_length and --output_prefix_length #139

Open
salsferrazza opened this issue Apr 21, 2023 · 0 comments
Labels
boundary condition The issue impacts statistically unlikely circumstances enhancement New feature or request

Comments

@salsferrazza
Copy link
Collaborator

LengthDelimitedOutputManager takes the --prefix_length command line option to size the int representing the prefix length for a message sent to the output stream. However, LengthDelimitedInputSource also uses the --prefix_length option for reading input streams that are length-prefixed.

The two options are distinct and should be separately instrumented. The clash namely occurs in a relatively rare situation, for example you are reframing messages and either narrowing or widening the prefix length as part of the process.

@salsferrazza salsferrazza added enhancement New feature or request boundary condition The issue impacts statistically unlikely circumstances labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boundary condition The issue impacts statistically unlikely circumstances enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant