Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOL Sysprep #234

Open
smkfuk opened this issue Aug 3, 2023 · 1 comment
Open

BYOL Sysprep #234

smkfuk opened this issue Aug 3, 2023 · 1 comment

Comments

@smkfuk
Copy link

smkfuk commented Aug 3, 2023

sysprep/activate_instance.ps1 will skip activation if the following folder exists:

if (Test-Path "$env:ProgramFiles\Google\Compute Engine\sysprep\byol_image") {
Write-Output 'Image imported into GCE via BYOL workflow, skipping GCE activation'
exit
}

However what process creates this path? We have tried various byol.wf.json and it always appears to try and activate with kms.windows.googlecloud.com

@bkatyl
Copy link
Contributor

bkatyl commented Aug 3, 2023

The creation is current in our import processes, but not the byol build workflows.

An open issue that should get some attention in the next few weeks is replacing this logic with instead looking at the License's listed in metadata for the instance, so it positively looks for a pay-as-you-go license from windows-cloud project.

They're listed at https://cloud.google.com/compute/docs/images/os-details#windows_server in the License tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants