Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for GOOGLE_CLOUD_UNIVERSE_DOMAIN env variable #1217

Open
jackwotherspoon opened this issue Dec 19, 2024 · 0 comments
Open

Add support for GOOGLE_CLOUD_UNIVERSE_DOMAIN env variable #1217

jackwotherspoon opened this issue Dec 19, 2024 · 0 comments
Assignees
@jackwotherspoon
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

Google Client libraries should check the env variable GOOGLE_CLOUD_UNIVERSE_DOMAIN as a secondary way of setting the TPC universe.

Priority should be as follows:

  1. Use universe_domain param of Connector if set
  2. Use GOOGLE_CLOUD_UNIVERSE_DOMAIN env variable if set
  3. Default to googleapis.com
@jackwotherspoon jackwotherspoon added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Dec 19, 2024
@jackwotherspoon jackwotherspoon self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackwotherspoon