Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of goog.isFunction #371

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

emaxx-google
Copy link
Collaborator

Refactor JavaScript code to use goog.functions.isFunction()
instead of goog.isFunction().

goog.isFunction() got deprecated and removed from the recent
versions of the Closure Library; for whatever reason, they decided to
add a synonym "goog.functions.isFunction".

This change contributes to the refactoring effort tracked by #264.

Copy link
Collaborator

@Fabian-Sommer Fabian-Sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emaxx-google emaxx-google force-pushed the roll--closure-library-20200719 branch from 5bc26cc to 92366cf Compare July 28, 2021 16:44
Base automatically changed from roll--closure-library-20200719 to master July 28, 2021 16:44
Refactor JavaScript code to use goog.functions.isFunction()
instead of goog.isFunction().

goog.isFunction() got deprecated and removed from the recent
versions of the Closure Library; for whatever reason, they decided to
add a synonym "goog.functions.isFunction".

This change contributes to the refactoring effort tracked by #264.
@emaxx-google emaxx-google merged commit f7ddae6 into master Jul 28, 2021
@emaxx-google emaxx-google deleted the js-moder--isfunction branch July 28, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants