Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable *.js reformatting in format-code.sh #365

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

emaxx-google
Copy link
Collaborator

@emaxx-google emaxx-google commented Jul 26, 2021

Change the format-code.sh developer script to also automatically reformat
any change JavaScript file.

In the past, all JS code written in this repository was formatted
manually. The plan is to switch to the clang-based automatic formatting,
and the first step on this route is to apply it to every changed file.

This contributes to the refactoring effort tracked by #264.

Change the format-code.shdeveloper script to also automatically reformat
any change JavaScript file.

In the past, all JS code written in this repository was formatted
manually. The plan is to switch to the clang-based automatic formatting,
and the first step on this route is to apply it to every changed file.

This contributes to the refactoring effort tracked by #264.
Copy link
Collaborator

@Fabian-Sommer Fabian-Sommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ayaNader ayaNader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emaxx-google emaxx-google merged commit 91453c8 into master Jul 27, 2021
@emaxx-google emaxx-google deleted the js-moder--clang-tidy-script branch July 27, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants