Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom props for video width and height. #32

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Add custom props for video width and height. #32

merged 2 commits into from
Aug 24, 2022

Conversation

jakearchibald
Copy link
Contributor

Part of #28

@jakearchibald jakearchibald mentioned this pull request Jul 25, 2022
Open
@jeffposnick jeffposnick requested a review from devnook July 25, 2022 15:49
tunetheweb
tunetheweb approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With caveats from #28 (comment) that need to be added later.

@devnook devnook merged commit ac4056a into GoogleChrome:main Aug 24, 2022
@matthiasrohmer matthiasrohmer mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

@devnook devnook Awaiting requested review from devnook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakearchibald @tunetheweb @devnook